Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update semsimian dependency version #717

Merged
merged 4 commits into from
Mar 18, 2024
Merged

Update semsimian dependency version #717

merged 4 commits into from
Mar 18, 2024

Conversation

hrshdhgd
Copy link
Collaborator

@hrshdhgd hrshdhgd commented Mar 14, 2024

  • Update semsimian dependency to latest version
  • Converted a bioportal implementation test to a mock API call since the test failed/is outdated with regards to data returned by the API call made.

@hrshdhgd hrshdhgd marked this pull request as ready for review March 14, 2024 22:40
@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.45%. Comparing base (a519291) to head (0f26477).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #717      +/-   ##
==========================================
- Coverage   75.46%   75.45%   -0.01%     
==========================================
  Files         268      268              
  Lines       31327    31328       +1     
==========================================
- Hits        23640    23638       -2     
- Misses       7687     7690       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hrshdhgd hrshdhgd requested a review from cmungall March 15, 2024 00:18
Copy link
Collaborator

@cmungall cmungall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to update the pyproject.toml too?

@hrshdhgd
Copy link
Collaborator Author

it was already >=0.1.0, so should work without a change. However, I did make the change just to be sure.

@hrshdhgd hrshdhgd requested a review from cmungall March 15, 2024 13:13
@hrshdhgd hrshdhgd merged commit 5dcedf5 into main Mar 18, 2024
9 checks passed
@hrshdhgd hrshdhgd deleted the semsimian-version-bump branch March 18, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants